[
https://issues.apache.org/jira/browse/HDFS-16660?focusedWorklogId=790527&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790527
]
ASF GitHub Bot logged work on HDFS-16660:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/22 17:29
Start Date: 13/Jul/22 17:29
Worklog Time Spent: 10m
Work Description: goiri commented on code in PR #4561:
URL: https://github.com/apache/hadoop/pull/4561#discussion_r920333291
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java:
##########
@@ -346,36 +324,25 @@ public void run() {
@Override
public ListenableFuture<Boolean> isFormatted() {
- return singleThreadExecutor.submit(new Callable<Boolean>() {
- @Override
- public Boolean call() throws IOException {
- return getProxy().isFormatted(journalId, nameServiceId);
- }
- });
+ return singleThreadExecutor.submit(
Review Comment:
Fits in one line
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java:
##########
@@ -346,36 +324,25 @@ public void run() {
@Override
public ListenableFuture<Boolean> isFormatted() {
- return singleThreadExecutor.submit(new Callable<Boolean>() {
- @Override
- public Boolean call() throws IOException {
- return getProxy().isFormatted(journalId, nameServiceId);
- }
- });
+ return singleThreadExecutor.submit(
+ () -> getProxy().isFormatted(journalId, nameServiceId));
}
@Override
public ListenableFuture<GetJournalStateResponseProto> getJournalState() {
- return singleThreadExecutor.submit(new
Callable<GetJournalStateResponseProto>() {
- @Override
- public GetJournalStateResponseProto call() throws IOException {
- GetJournalStateResponseProto ret =
- getProxy().getJournalState(journalId, nameServiceId);
- constructHttpServerURI(ret);
- return ret;
- }
+ return singleThreadExecutor.submit(() -> {
+ GetJournalStateResponseProto ret =
Review Comment:
Fits in one line
Issue Time Tracking
-------------------
Worklog Id: (was: 790527)
Time Spent: 20m (was: 10m)
> Improve Code With Lambda in IPCLoggerChannel class
> --------------------------------------------------
>
> Key: HDFS-16660
> URL: https://issues.apache.org/jira/browse/HDFS-16660
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Improve Code With Lambda in IPCLoggerChannel class
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
