[
https://issues.apache.org/jira/browse/HDFS-16655?focusedWorklogId=791852&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-791852
]
ASF GitHub Bot logged work on HDFS-16655:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/22 05:41
Start Date: 18/Jul/22 05:41
Worklog Time Spent: 10m
Work Description: Hexiaoqiao commented on code in PR #4541:
URL: https://github.com/apache/hadoop/pull/4541#discussion_r922981175
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageTextWriter.java:
##########
@@ -17,16 +17,7 @@
*/
package org.apache.hadoop.hdfs.tools.offlineImageViewer;
-import java.io.BufferedInputStream;
-import java.io.Closeable;
-import java.io.File;
-import java.io.FileInputStream;
-import java.io.FileOutputStream;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.PrintStream;
-import java.io.RandomAccessFile;
-import java.io.UnsupportedEncodingException;
+import java.io.*;
Review Comment:
Please expand the imports rather than use wildcard.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java:
##########
@@ -80,6 +80,7 @@ public class OfflineImageViewerPB {
+ " delimiter. The default delimiter is \\t, though this may be\n"
+ " changed via the -delimiter argument.\n"
+ " -sp print storage policy, used by delimiter only.\n"
+ + " -ec print erasure coding policy policy, used by delimiter only.\n"
Review Comment:
duplicate word `policy` here.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageDelimitedTextWriter.java:
##########
@@ -146,14 +168,21 @@ public String build() {
PBImageDelimitedTextWriter(PrintStream out, String delimiter,
String tempPath, boolean printStoragePolicy)
throws IOException {
- this(out, delimiter, tempPath, printStoragePolicy, 1, "-");
+ this(out, delimiter, tempPath, printStoragePolicy, 1, "-", null, false);
}
PBImageDelimitedTextWriter(PrintStream out, String delimiter,
- String tempPath, boolean printStoragePolicy, int threads,
- String parallelOut) throws IOException {
+ String tempPath, boolean printStoragePolicy,
+ int threads, String parallelOut,
+ Configuration conf, boolean printECPolicy)
Review Comment:
I think it may be better to define this method as the following.
```
PBImageDelimitedTextWriter(PrintStream out, String delimiter,
String tempPath, boolean printStoragePolicy,
boolean printECPolicy, int threads, String
parallelOut,
Configuration conf)
```
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForErasureCodingPolicy.java:
##########
@@ -0,0 +1,181 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hdfs.tools.offlineImageViewer;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FSDataOutputStream;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hdfs.DFSConfigKeys;
+import org.apache.hadoop.hdfs.DFSTestUtil;
+import org.apache.hadoop.hdfs.DistributedFileSystem;
+import org.apache.hadoop.hdfs.MiniDFSCluster;
+import org.apache.hadoop.hdfs.protocol.HdfsConstants;
+import org.apache.hadoop.hdfs.server.namenode.FSImageTestUtil;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.*;
Review Comment:
Please expand this wildcard import.
Issue Time Tracking
-------------------
Worklog Id: (was: 791852)
Time Spent: 1h 10m (was: 1h)
> OIV: print out erasure coding policy name in oiv Delimited output
> -----------------------------------------------------------------
>
> Key: HDFS-16655
> URL: https://issues.apache.org/jira/browse/HDFS-16655
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: tools
> Affects Versions: 3.4.0
> Reporter: Max Xie
> Assignee: Max Xie
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> By adding erasure coding policy name to oiv output, it will help with oiv
> post-analysis to have a overview of all folders/files with specified ec
> policy and to apply internal regulation based on this information. In
> particular, it wiil be convenient for the platform to calculate the real
> storage size of the ec file.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
