[
https://issues.apache.org/jira/browse/HDFS-16619?focusedWorklogId=795850&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795850
]
ASF GitHub Bot logged work on HDFS-16619:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jul/22 00:04
Start Date: 28/Jul/22 00:04
Worklog Time Spent: 10m
Work Description: jojochuang commented on code in PR #4406:
URL: https://github.com/apache/hadoop/pull/4406#discussion_r931673249
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/web/TestDatanodeHttpXFrame.java:
##########
@@ -69,7 +68,7 @@ public void testNameNodeXFrameOptionsDisabled() throws
Exception {
cluster = createCluster(xFrameEnabled, null);
HttpURLConnection conn = getConn(cluster);
String xfoHeader = conn.getHeaderField("X-FRAME-OPTIONS");
- Assert.assertTrue("unexpected X-FRAME-OPTION in header", xfoHeader ==
null);
+ Assert.assertNull(xfoHeader);
Review Comment:
```suggestion
Assert.assertNull("unexpected X-FRAME-OPTION in header", xfoHeader);
```
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/web/webhdfs/TestDataNodeUGIProvider.java:
##########
@@ -246,9 +246,9 @@ private WebHdfsFileSystem
getWebHdfsFileSystem(UserGroupInformation ugi,
DelegationTokenSecretManager dtSecretManager = new
DelegationTokenSecretManager(
86400000, 86400000, 86400000, 86400000, namesystem);
dtSecretManager.startThreads();
- Token<DelegationTokenIdentifier> token1 = new
Token<DelegationTokenIdentifier>(
+ Token<DelegationTokenIdentifier> token1 = new Token<>(
Review Comment:
Unrelated change.
Issue Time Tracking
-------------------
Worklog Id: (was: 795850)
Time Spent: 4h (was: 3h 50m)
> Fix HttpHeaders.Values And HttpHeaders.Names Deprecated Import.
> ---------------------------------------------------------------
>
> Key: HDFS-16619
> URL: https://issues.apache.org/jira/browse/HDFS-16619
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments: Fix HttpHeaders.Values And HttpHeaders.Names
> Deprecated.png
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> HttpHeaders.Values and HttpHeaders.Names are deprecated, use
> HttpHeaderValues and HttpHeaderNames instead.
> HttpHeaders.Names
> Deprecated.
> Use HttpHeaderNames instead. Standard HTTP header names.
> {code:java}
> /** @deprecated */
> @Deprecated
> public static final class Names {
> public static final String ACCEPT = "Accept";
> public static final String ACCEPT_CHARSET = "Accept-Charset";
> public static final String ACCEPT_ENCODING = "Accept-Encoding";
> public static final String ACCEPT_LANGUAGE = "Accept-Language";
> public static final String ACCEPT_RANGES = "Accept-Ranges";
> public static final String ACCEPT_PATCH = "Accept-Patch";
> public static final String ACCESS_CONTROL_ALLOW_CREDENTIALS =
> "Access-Control-Allow-Credentials";
> public static final String ACCESS_CONTROL_ALLOW_HEADERS =
> "Access-Control-Allow-Headers"; {code}
> HttpHeaders.Values
> Deprecated.
> Use HttpHeaderValues instead. Standard HTTP header values.
> {code:java}
> /** @deprecated */
> @Deprecated
> public static final class Values {
> public static final String APPLICATION_JSON = "application/json";
> public static final String APPLICATION_X_WWW_FORM_URLENCODED =
> "application/x-www-form-urlencoded";
> public static final String BASE64 = "base64";
> public static final String BINARY = "binary";
> public static final String BOUNDARY = "boundary";
> public static final String BYTES = "bytes";
> public static final String CHARSET = "charset";
> public static final String CHUNKED = "chunked";
> public static final String CLOSE = "close"; {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
