[
https://issues.apache.org/jira/browse/HDFS-16703?focusedWorklogId=796613&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796613
]
ASF GitHub Bot logged work on HDFS-16703:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jul/22 13:20
Start Date: 30/Jul/22 13:20
Worklog Time Spent: 10m
Work Description: ZanderXu commented on PR #4660:
URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1200156797
@slfan1989 Thanks for your review.
> I feel that this change is a bit risky, will this lead to instability of
the service? Sometimes it is reasonable to configure without timeout
Sorry, I didn't get your idea. Can you share more detailed information or
cases?
> The main question is is it reasonable to use the same timeout
configuration for different protocols?
According to my practical experience, using one configuration
`ipc.client.rpc-timeout.ms` is enough. Of course, if some masters feel it is
necessary to distinguish this configuration, I will modify this patch.
Issue Time Tracking
-------------------
Worklog Id: (was: 796613)
Time Spent: 40m (was: 0.5h)
> Enable RPC Timeout for some protocols of NameNode.
> --------------------------------------------------
>
> Key: HDFS-16703
> URL: https://issues.apache.org/jira/browse/HDFS-16703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When I read some code about protocol, I found that only
> ClientNamenodeProtocolPB proxy with RPC timeout, other protocolPB proxy
> without RPC timeout, such as RefreshAuthorizationPolicyProtocolPB,
> RefreshUserMappingsProtocolPB, RefreshCallQueueProtocolPB,
> GetUserMappingsProtocolPB and NamenodeProtocolPB.
>
> If proxy without rpc timeout, it will be blocked for a long time if the NN
> machine crash or bad network during writing or reading with NN.
>
> So I feel that we should enable RPC timeout for all ProtocolPB.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
