[
https://issues.apache.org/jira/browse/HDFS-16710?focusedWorklogId=796967&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796967
]
ASF GitHub Bot logged work on HDFS-16710:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/22 17:42
Start Date: 01/Aug/22 17:42
Worklog Time Spent: 10m
Work Description: goiri commented on code in PR #4670:
URL: https://github.com/apache/hadoop/pull/4670#discussion_r934768914
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/CheckpointFaultInjector.java:
##########
@@ -36,9 +36,9 @@ public static void set(CheckpointFaultInjector instance) {
CheckpointFaultInjector.instance = instance;
}
public void beforeGetImageSetsHeaders() throws IOException {}
- public void afterSecondaryCallsRollEditLog() throws IOException {}
Review Comment:
What is the source for so many wrong definitions?
Issue Time Tracking
-------------------
Worklog Id: (was: 796967)
Time Spent: 20m (was: 10m)
> Remove redundant throw exceptions in org.apahce.hadoop.hdfs.server.namenode
> package
> -----------------------------------------------------------------------------------
>
> Key: HDFS-16710
> URL: https://issues.apache.org/jira/browse/HDFS-16710
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When I read some class about HDFS NameNode, I found there are many redundant
> throw exception in org.apahce.hadoop.hdfs.server.namenode package, such as:
> {code:java}
> public synchronized void transitionToObserver(StateChangeRequestInfo req)
> throws ServiceFailedException, AccessControlException, IOException {
> checkNNStartup();
> nn.checkHaStateChange(req);
> nn.transitionToObserver();
> } {code}
> Because ServiceFailedException and AccessControlException is subClass of
> IOException, so I feel that ServiceFailedException and AccessControlException
> are redundant, so we can remove it to make code clearer, such as:
> {code:java}
> public synchronized void transitionToObserver(StateChangeRequestInfo req)
> throws IOException {
> checkNNStartup();
> nn.checkHaStateChange(req);
> nn.transitionToObserver();
> } {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
