[
https://issues.apache.org/jira/browse/HDFS-16707?focusedWorklogId=796968&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796968
]
ASF GitHub Bot logged work on HDFS-16707:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/22 17:44
Start Date: 01/Aug/22 17:44
Worklog Time Spent: 10m
Work Description: goiri commented on code in PR #4665:
URL: https://github.com/apache/hadoop/pull/4665#discussion_r934770189
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java:
##########
@@ -1580,7 +1580,7 @@ private void acquirePermit(final String nsId, final
UserGroupInformation ugi,
// Throw StandByException,
// Clients could fail over and try another router.
if (rpcMonitor != null) {
- rpcMonitor.getRPCMetrics().incrProxyOpPermitRejected();
Review Comment:
Should we keep the old method too?
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcMonitor.java:
##########
@@ -74,7 +74,17 @@ void init(
* exception.
*/
void proxyOpFailureCommunicate(String nsId);
+
+ /**
+ * Rejected to proxy an operation to a Namenode.
+ */
+ void ProxyOpPermitRejected(String nsId);
Review Comment:
lower case p?
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java:
##########
@@ -1590,6 +1590,9 @@ private void acquirePermit(final String nsId, final
UserGroupInformation ugi,
" is overloaded for NS: " + nsId;
throw new StandbyException(msg);
}
+ if (rpcMonitor!= null) {
Review Comment:
spacing
Issue Time Tracking
-------------------
Worklog Id: (was: 796968)
Time Spent: 0.5h (was: 20m)
> RBF: Expose RouterRpcFairnessPolicyController related request record metrics
> for each nameservice to Prometheus
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-16707
> URL: https://issues.apache.org/jira/browse/HDFS-16707
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Jiale Qi
> Assignee: Jiale Qi
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> HDFS-16302 intoduced request recored for each namespace, but it is only
> exposed in /jmx endpoint and in json format, not very convenient.
> this patch exposed these metrics in /prom endpoint for Prometheus
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
