[ 
https://issues.apache.org/jira/browse/HDFS-16695?focusedWorklogId=797278&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797278
 ]

ASF GitHub Bot logged work on HDFS-16695:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Aug/22 15:44
            Start Date: 02/Aug/22 15:44
    Worklog Time Spent: 10m 
      Work Description: ZanderXu commented on PR #4668:
URL: https://github.com/apache/hadoop/pull/4668#issuecomment-1202863699

   @goiri @slfan1989 Sir, I have updated this patch, please help me review it. 
Thanks 
   
   1. Just improved code with Lambda in namenode package
   2. Removed some code that has nothing to do with lambdas 




Issue Time Tracking
-------------------

    Worklog Id:     (was: 797278)
    Time Spent: 1h 40m  (was: 1.5h)

> Improve Code with Lambda in org.apahce.hadoop.hdfs.server.namenode package
> --------------------------------------------------------------------------
>
>                 Key: HDFS-16695
>                 URL: https://issues.apache.org/jira/browse/HDFS-16695
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: ZanderXu
>            Assignee: ZanderXu
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Improve Code with Lambda in org.apahce.hadoop.hdfs.server.namenode package.
> For example:
> Current logic:
> {code:java}
> public ListenableFuture<GetJournaledEditsResponseProto> getJournaledEdits(
>       long fromTxnId, int maxTransactions) {
>     return parallelExecutor.submit(
>         new Callable<GetJournaledEditsResponseProto>() {
>           @Override
>           public GetJournaledEditsResponseProto call() throws IOException {
>             return getProxy().getJournaledEdits(journalId, nameServiceId,
>                 fromTxnId, maxTransactions);
>           }
>         });
>   }
> {code}
> Improved Code with Lambda:
> {code:java}
> public ListenableFuture<GetJournaledEditsResponseProto> getJournaledEdits(
>       long fromTxnId, int maxTransactions) {
>     return parallelExecutor.submit(() -> getProxy().getJournaledEdits(
>         journalId, nameServiceId, fromTxnId, maxTransactions));
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to