[
https://issues.apache.org/jira/browse/HDFS-16700?focusedWorklogId=797403&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797403
]
ASF GitHub Bot logged work on HDFS-16700:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Aug/22 21:38
Start Date: 02/Aug/22 21:38
Worklog Time Spent: 10m
Work Description: goiri commented on code in PR #4659:
URL: https://github.com/apache/hadoop/pull/4659#discussion_r936047891
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java:
##########
@@ -2070,6 +2077,46 @@ public void testSetBalancerBandwidth() throws Exception {
}, 100, 60 * 1000);
}
+ @Test
+ public void testRecordRealClient() throws Exception {
Review Comment:
Does it make sense to refactor this into a general function and call it with
the two configs?
The other interesting part would be to log the output too.
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java:
##########
@@ -121,6 +121,44 @@ public String toString() {
return str;
}
+ private static String parseSpecialValue(String content, String key) {
+ int posn = content.indexOf(key);
Review Comment:
Small javadoc with an example
Issue Time Tracking
-------------------
Worklog Id: (was: 797403)
Time Spent: 2.5h (was: 2h 20m)
> RBF: Record the real client IP carried by the Router in the NameNode log
> ------------------------------------------------------------------------
>
> Key: HDFS-16700
> URL: https://issues.apache.org/jira/browse/HDFS-16700
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode, rbf
> Affects Versions: 3.3.3
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Here are some logs recorded by the NameNode when using RBF:
> {code:java}
> 2022-07-28 19:31:07,126 INFO ipc.Server: IPC Server handler 8 on default port
> 8020, call Call#127 Retry#0
> org.apache.hadoop.hdfs.protocol.ClientProtocol.getFileInfo from
> 172.10.100.67:58001
> {code}
> The ip information here is still the router. If the real client ip is
> recorded, it will more clearly express where the request comes from.
> E.g:
> {code:java}
> 2022-07-29 19:31:07,126 INFO ipc.Server: IPC Server handler 8 on default port
> 8020, call Call#127 Retry#0
> org.apache.hadoop.hdfs.protocol.ClientProtocol.getFileInfo from
> 172.10.100.67:58001, client=172.111.65.123:43232
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
