[
https://issues.apache.org/jira/browse/HDFS-16702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17577559#comment-17577559
]
ASF GitHub Bot commented on HDFS-16702:
---------------------------------------
steveloughran commented on code in PR #4680:
URL: https://github.com/apache/hadoop/pull/4680#discussion_r941637121
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java:
##########
@@ -2159,10 +2159,10 @@ public void shutdown(boolean deleteDfsDir, boolean
closeFileSystem) {
LOG.info("Shutting down the Mini HDFS Cluster");
if (checkExitOnShutdown) {
if (ExitUtil.terminateCalled()) {
- LOG.error("Test resulted in an unexpected exit",
- ExitUtil.getFirstExitException());
Review Comment:
having the full exception thrown helps with IDE integration...
> MiniDFSCluster should report cause of exception in assertion error
> ------------------------------------------------------------------
>
> Key: HDFS-16702
> URL: https://issues.apache.org/jira/browse/HDFS-16702
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Environment: Tests running in the Hadoop dev environment image.
> Reporter: Steve Vaughan
> Assignee: Steve Vaughan
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> When the MiniDFSClsuter detects that an exception caused an exit, it should
> include that exception as the cause for the AssertionError that it throws.
> The current AssertError simply reports the message "Test resulted in an
> unexpected exit" and provides a stack trace to the location of the check for
> an exit exception.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
