[
https://issues.apache.org/jira/browse/HDFS-16705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578785#comment-17578785
]
ASF GitHub Bot commented on HDFS-16705:
---------------------------------------
slfan1989 commented on PR #4662:
URL: https://github.com/apache/hadoop/pull/4662#issuecomment-1212720519
> It looks good from my side but I'd like to get closure from @slfan1989
LGTM.
@ZanderXu Thank you for your contribution, @goiri Thank you for helping to
review the code.
> RBF: Support healthMonitor timeout configurable and cache NN and client proxy
> in NamenodeHeartbeatService
> ---------------------------------------------------------------------------------------------------------
>
> Key: HDFS-16705
> URL: https://issues.apache.org/jira/browse/HDFS-16705
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> When I read NamenodeHeartbeatService.class of RBF, I feel that there are
> somethings we can do for NamenodeHeartbeatService.class.
> * Cache NameNode Protocol and Client Protocol to avoid creating a new proxy
> every time
> * Supports healthMonitorTimeout configuration
> * Format code of getNamenodeStatusReport to make it clearer
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
