[
https://issues.apache.org/jira/browse/HDFS-16703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579904#comment-17579904
]
ASF GitHub Bot commented on HDFS-16703:
---------------------------------------
goiri commented on PR #4660:
URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1215773135
> @slfan1989 Thanks for your review.
>
> > Do we need to update the md file to explain what these parameters do?
>
> Do you mean which MD file? `ipc.client.rpc-timeout.ms` is not been
explained. If you think we should do it, I will add some explanation for them.
I'm not sure what is the best place to document.
TBH, I do not see a good place to document this; so it might be best to just
have it in the XML.
> Enable RPC Timeout for some protocols of NameNode.
> --------------------------------------------------
>
> Key: HDFS-16703
> URL: https://issues.apache.org/jira/browse/HDFS-16703
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> When I read some code about protocol, I found that only
> ClientNamenodeProtocolPB proxy with RPC timeout, other protocolPB proxy
> without RPC timeout, such as RefreshAuthorizationPolicyProtocolPB,
> RefreshUserMappingsProtocolPB, RefreshCallQueueProtocolPB,
> GetUserMappingsProtocolPB and NamenodeProtocolPB.
>
> If proxy without rpc timeout, it will be blocked for a long time if the NN
> machine crash or bad network during writing or reading with NN.
>
> So I feel that we should enable RPC timeout for all ProtocolPB.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
