[
https://issues.apache.org/jira/browse/HDFS-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581994#comment-17581994
]
ASF GitHub Bot commented on HDFS-16684:
---------------------------------------
snmvaughan commented on code in PR #4723:
URL: https://github.com/apache/hadoop/pull/4723#discussion_r950495340
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNodeSyncer.java:
##########
@@ -153,7 +156,8 @@ private boolean getOtherJournalNodeProxies() {
LOG.warn("Could not add proxy for Journal at addresss " + addr, e);
}
}
- if (otherJNProxies.isEmpty()) {
+ // Check if any of there are any resolvable JournalNodes before starting
the sync.
Review Comment:
I've realized that not starting the syncer because the addresses are
unresolved is counter-productive. The act of attempting to sync instigates
attempts to communicate with the other servers, which will result in resolution
if they are available. I'll restart the original check for "are there any
other configured proxies".
> Exclude self from JournalNodeSyncer when using a bind host
> ----------------------------------------------------------
>
> Key: HDFS-16684
> URL: https://issues.apache.org/jira/browse/HDFS-16684
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: journal-node
> Environment: Running with Java 11 and bind addresses set to 0.0.0.0.
> Reporter: Steve Vaughan
> Assignee: Steve Vaughan
> Priority: Major
> Labels: pull-request-available
>
> The JournalNodeSyncer will include the local instance in syncing when using a
> bind host (e.g. 0.0.0.0). There is a mechanism that is supposed to exclude
> the local instance, but it doesn't recognize the meta-address as a local
> address.
> Running with bind addresses set to 0.0.0.0, the JournalNodeSyncer will log
> attempts to sync with itself as part of the normal syncing rotation. For an
> HA configuration running 3 JournalNodes, the "other" list used by the
> JournalNodeSyncer will include 3 proxies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
