[ 
https://issues.apache.org/jira/browse/HDFS-16686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583192#comment-17583192
 ] 

ASF GitHub Bot commented on HDFS-16686:
---------------------------------------

sunchao commented on code in PR #4724:
URL: https://github.com/apache/hadoop/pull/4724#discussion_r951896386


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/MiniQJMHACluster.java:
##########
@@ -35,7 +35,7 @@
 import java.util.List;
 import java.util.Random;
 
-public class MiniQJMHACluster {
+public class MiniQJMHACluster implements AutoCloseable {

Review Comment:
   Yes, but it changes the signatures so it no longer throw `IOException`, so 
all the call sites of this method should no longer need to catch that 
exception. 
   
   I'd prefer to do this separately if not related to this PR.





> GetJournalEditServlet fails to authorize valid Kerberos request
> ---------------------------------------------------------------
>
>                 Key: HDFS-16686
>                 URL: https://issues.apache.org/jira/browse/HDFS-16686
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: journal-node
>         Environment: Running in Kubernetes using Java 11 in an HA 
> configuration.  JournalNodes run on separate pods and have their own Kerberos 
> principal "jn/<hostname>@<realm>".
>            Reporter: Steve Vaughan
>            Assignee: Steve Vaughan
>            Priority: Major
>              Labels: pull-request-available
>
> GetJournalEditServlet uses request.getRemoteuser() to determine the 
> remoteShortName for Kerberos authorization, which fails to match when the 
> JournalNode uses its own Kerberos principal (e.g. jn/<hostname>@<realm>).
> This can be fixed by using the UserGroupInformation provided by the base 
> DfsServlet class using the getUGI(request, conf) call.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to