[
https://issues.apache.org/jira/browse/HDFS-16737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584291#comment-17584291
]
ASF GitHub Bot commented on HDFS-16737:
---------------------------------------
ayushtkn commented on code in PR #4784:
URL: https://github.com/apache/hadoop/pull/4784#discussion_r953896405
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java:
##########
@@ -151,9 +151,9 @@ public class DFSConfigKeys extends CommonConfigurationKeys {
public static final long DFS_DATANODE_MAX_LOCKED_MEMORY_DEFAULT = 0;
public static final String
DFS_DATANODE_FSDATASETCACHE_MAX_THREADS_PER_VOLUME_KEY =
"dfs.datanode.fsdatasetcache.max.threads.per.volume";
public static final int
DFS_DATANODE_FSDATASETCACHE_MAX_THREADS_PER_VOLUME_DEFAULT = 4;
- public static final String
DFS_DATANODE_FSDATASETASYNCDISK_MAX_THREADS_PER_VOLUME_KEY =
- "dfs.datanode.fsdatasetasyncdisk.max.threads.per.volume";
- public static final int
DFS_DATANODE_FSDATASETASYNCDISK_MAX_THREADS_PER_VOLUME_DEFAULT = 4;
+ public static final String
DFS_DATANODE_FSDATASETASYNCDISK_THREADS_PER_VOLUME_KEY =
+ "dfs.datanode.fsdatasetasyncdisk.threads.per.volume";
+ public static final int
DFS_DATANODE_FSDATASETASYNCDISK_THREADS_PER_VOLUME_DEFAULT = 1;
Review Comment:
you can't change the config name if that is there in a released version.
> Fix number of threads in FsDatasetAsyncDiskService#addExecutorForVolume
> -----------------------------------------------------------------------
>
> Key: HDFS-16737
> URL: https://issues.apache.org/jira/browse/HDFS-16737
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
>
> The number of threads in FsDatasetAsyncDiskService#addExecutorForVolume is
> elastic right now, make it fixed.
> Presently the corePoolSize is set to 1 and maximumPoolSize is set to
> maxNumThreadsPerVolume, but since the size of Queue is Integer.MAX, the queue
> doesn't tend to get full and threads are always confined to 1 irrespective of
> maxNumThreadsPerVolume.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
