[ 
https://issues.apache.org/jira/browse/HDFS-16767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603784#comment-17603784
 ] 

ASF GitHub Bot commented on HDFS-16767:
---------------------------------------

simbadzina commented on code in PR #4127:
URL: https://github.com/apache/hadoop/pull/4127#discussion_r970105963


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java:
##########
@@ -478,8 +498,13 @@ public Object invokeMethod(
       rpcMonitor.proxyOp();
     }
     boolean failover = false;
+    boolean tryActive = false;

Review Comment:
   We don't need an extra variable. I now set `shouldUseObserver` to false if 
there is a RetryException from the Observer.





> RBF: Support observer node from Router-Based Federation 
> --------------------------------------------------------
>
>                 Key: HDFS-16767
>                 URL: https://issues.apache.org/jira/browse/HDFS-16767
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Simbarashe Dzinamarira
>            Assignee: Simbarashe Dzinamarira
>            Priority: Major
>              Labels: pull-request-available
>
> Enable routers to direct read calls to observer namenodes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to