[
https://issues.apache.org/jira/browse/HDFS-16787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615073#comment-17615073
]
ASF GitHub Bot commented on HDFS-16787:
---------------------------------------
Hexiaoqiao commented on PR #4948:
URL: https://github.com/apache/hadoop/pull/4948#issuecomment-1273218260
@ZanderXu BTW, have you filed JIRA to track this failed unit test
ever(TestObserverNode)? I found it has arisen times.
> Remove the redundant lock in DataSetLockManager#removeLock.
> -----------------------------------------------------------
>
> Key: HDFS-16787
> URL: https://issues.apache.org/jira/browse/HDFS-16787
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> During patching the datanode fine-grained locking, found there is a redundant
> lock in DataSetLockManager#removeLock, and the code as bellow:
> {code:java}
> @Override
> public void removeLock(LockLevel level, String... resources) {
> String lockName = generateLockName(level, resources);
> try (AutoCloseDataSetLock lock = writeLock(level, resources)) {
> // Here, this lock is redundant.
> lock.lock();
> lockMap.removeLock(lockName);
> }
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
