[
https://issues.apache.org/jira/browse/HDFS-16802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617426#comment-17617426
]
ASF GitHub Bot commented on HDFS-16802:
---------------------------------------
jianghuazhu commented on code in PR #5013:
URL: https://github.com/apache/hadoop/pull/5013#discussion_r995305422
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java:
##########
@@ -249,7 +249,7 @@ static RenameResult renameToInt(
String dst = dstArg;
if (NameNode.stateChangeLog.isDebugEnabled()) {
NameNode.stateChangeLog.debug("DIR* NameSystem.renameTo: with options -"
+
- " " + src + " to " + dst);
+ " {} to {}, options={}", src, dst, Arrays.toString(options));
Review Comment:
I agree.
Here are some audit logs:
`
2022-10-14 11:16:30,825 [Listener at localhost/51113] INFO
FSNamesystem.audit (FSNamesystem.java:logAuditMessage(8853)) - allowed=true
ugi=hdfs (auth:SIMPLE) ip=null cmd=rename ( options=[NONE])
src=/testNamenodeRetryCache/testRename2/src
dst=/testNamenodeRetryCache/testRename2/target perm=hdfs:supergroup:rwxrwxrwx
proto=null
`
Should we keep a consistent norm?
New format:
`
2022-10-14 11:20:18,813 [Listener at localhost/58086] DEBUG
hdfs.StateChange(FSDirRenameOp.java:renameToInt(256)) - DIR*
NameSystem.renameTo: with options=[NONE]
/testNamenodeRetryCache/testRename2/src to /testNamenodeRetryCache
/testRename2/target
`
> Print options when accessing ClientProtocol#rename2()
> -----------------------------------------------------
>
> Key: HDFS-16802
> URL: https://issues.apache.org/jira/browse/HDFS-16802
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 3.3.4
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Minor
> Labels: pull-request-available
>
> When accessing ClientProtocol#rename2(), the carried options cannot be seen
> in the log. Here is some log information:
> {code:java}
> 2022-10-13 10:21:10,727 [Listener at localhost/59732] DEBUG hdfs.StateChange
> (FSDirRenameOp.java:renameToInt(255)) - DIR* NameSystem.renameTo: with
> options - /testNamenodeRetryCache/testRename2/src to
> /testNamenodeRetryCache/testRename2/target
> {code}
> We should improve this, maybe printing options would be better.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
