[
https://issues.apache.org/jira/browse/HDFS-16811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626148#comment-17626148
]
ASF GitHub Bot commented on HDFS-16811:
---------------------------------------
tomscut commented on code in PR #5068:
URL: https://github.com/apache/hadoop/pull/5068#discussion_r1008774315
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##########
@@ -2601,6 +2611,36 @@ private String reconfigureBlockInvalidateLimit(final
DatanodeManager datanodeMan
}
}
+ private String reconfigureDecommissionBackoffMonitorParameters(
+ final DatanodeManager datanodeManager, final String property, final
String newVal)
+ throws ReconfigurationException {
+ String newSetting;
+ try {
+ if
(property.equals(DFS_NAMENODE_DECOMMISSION_BACKOFF_MONITOR_PENDING_LIMIT)) {
+ int pendingRepLimit = (newVal == null ?
+ DFS_NAMENODE_DECOMMISSION_BACKOFF_MONITOR_PENDING_LIMIT_DEFAULT :
+ Integer.parseInt(newVal));
+
datanodeManager.getDatanodeAdminManager().refreshPendingRepLimit(pendingRepLimit,
+ DFS_NAMENODE_DECOMMISSION_BACKOFF_MONITOR_PENDING_LIMIT);
+ newSetting =
String.valueOf(datanodeManager.getDatanodeAdminManager().getPendingRepLimit());
+ } else if
(property.equals(DFS_NAMENODE_DECOMMISSION_BACKOFF_MONITOR_PENDING_BLOCKS_PER_LOCK))
{
Review Comment:
Please fix the checkstyles warn here.
> Support to make dfs.namenode.decommission.backoff.monitor.pending.limit
> reconfigurable
> ---------------------------------------------------------------------------------------
>
> Key: HDFS-16811
> URL: https://issues.apache.org/jira/browse/HDFS-16811
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
>
> When the Backoff monitor is enabled, the parameter
> dfs.namenode.decommission.backoff.monitor.pending.limit can be dynamically
> adjusted to determines the maximum number of blocks related to decommission
> and maintenance operations that can be loaded into the replication queue.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
