[
https://issues.apache.org/jira/browse/HDFS-16791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628601#comment-17628601
]
ASF GitHub Bot commented on HDFS-16791:
---------------------------------------
mccormickt12 commented on PR #4967:
URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1302808254
@steveloughran I can't comment on your long comment above,
> Looking at the specification, I'm not sure that `getRootPath()` is the
right name, given that the root dir is "/" everywhere -and very special (you
can delete it and it is still there afterwards). (it defined in model.md)
>
> What about `getMountRoot()`, as that is clearer at what it is.
The current name being proposed is `getEnclosingRoot` which I do think is
more generic since its not just mount roots.
As for the tests you listed, I have all of them somewhere except for
> wrapped invocation is unchanged.
I will work on this. I'm still not clear where all you want all these tests
replicated to.
For the below, im not sure what you are referring to. I see
`AbstractFSContract` but that seems pretty bare, im not sure if thats what you
are referring to or something else.
> for all tests of the specification which are expected to be met by all
filesystems -not just hdfs/viewfs- we need a contract test subclass of
AbstractFSC
> New API for enclosing root path for a file
> ------------------------------------------
>
> Key: HDFS-16791
> URL: https://issues.apache.org/jira/browse/HDFS-16791
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Tom McCormick
> Assignee: Tom McCormick
> Priority: Major
> Labels: pull-request-available
>
> At LinkedIn we run many HDFS volumes that are federated by either
> ViewFilesystem or Router Based Federation. As our number of hdfs volumes
> grows, we have a growing need to migrate data seemlessly across volumes.
> Many frameworks have a notion of staging or temp directories, but those
> directories often live in random locations. We want an API getEnclosingRoot,
> which provides the root path a file or dataset.
> In ViewFilesystem / Router Based Federation, the enclosingRoot will be the
> mount point.
> We will also take into account other restrictions for renames like
> encryptions zones.
> If there are several paths (a mount point and an encryption zone), we will
> return the longer path
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
