[
https://issues.apache.org/jira/browse/HDFS-15383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629396#comment-17629396
]
ASF GitHub Bot commented on HDFS-15383:
---------------------------------------
melissayou opened a new pull request, #5112:
URL: https://github.com/apache/hadoop/pull/5112
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
As part of
[HADOOP-18518](https://issues.apache.org/jira/browse/HADOOP-18518), this is the
second PR to fix deprecation of PathChildrenCache/TreeCache in new ZK. It's a
clean cherry pick from HDFS-15383 and HADOOP-17835.
### How was this patch tested?
`mvn clean install -Pdist -Dtar -DskipTests -Dmaven.javadoc.skip` build
success
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> RBF: Disable watch in ZKDelegationSecretManager for performance
> ---------------------------------------------------------------
>
> Key: HDFS-15383
> URL: https://issues.apache.org/jira/browse/HDFS-15383
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Fengnan Li
> Assignee: Fengnan Li
> Priority: Major
> Fix For: 3.4.0
>
>
> Based on the current design for delegation token in secure Router, the total
> number of watches for tokens is the product of number of routers and number
> of tokens, this is due to ZKDelegationTokenManager is using PathChildrenCache
> from curator, which automatically sets the watch and ZK will push the sync
> information to each router. There are some evaluations about the number of
> watches in Zookeeper has negative performance impact to Zookeeper server.
> In our practice when the number of watches exceeds 1.2 Million in a single ZK
> server there will be significant ZK performance degradation. Thus this ticket
> is to rewrite ZKDelegationTokenManagerImpl.java to explicitly disable the
> PathChildrenCache and have Routers sync periodically from Zookeeper. This has
> been working fine at the scale of 10 Routers with 2 million tokens.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]