[
https://issues.apache.org/jira/browse/HDFS-16834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631515#comment-17631515
]
ASF GitHub Bot commented on HDFS-16834:
---------------------------------------
ZanderXu commented on code in PR #5121:
URL: https://github.com/apache/hadoop/pull/5121#discussion_r1018780581
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestPoolAlignmentContext.java:
##########
@@ -0,0 +1,54 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hdfs.server.federation.router;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.ipc.protobuf.RpcHeaderProtos.RpcRequestHeaderProto;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+
+public class TestPoolAlignmentContext {
+ @Test
+ public void testNamenodeRequestsOnlyUsePoolLocalStateID() {
+ RouterStateIdContext routerStateIdContext = new RouterStateIdContext(new
Configuration());
+ String namespaceId = "namespace1";
+ routerStateIdContext.getNamespaceStateId(namespaceId).accumulate(20L);
+ PoolAlignmentContext poolContext1 = new
PoolAlignmentContext(routerStateIdContext, namespaceId);
+ PoolAlignmentContext poolContext2 = new
PoolAlignmentContext(routerStateIdContext, namespaceId);
+
+ routerStateIdContext.getNamespaceStateId(namespaceId).accumulate(20L);
Review Comment:
Can remove this useless line.
> PoolAlignmentContext should not max poolLocalStateId with sharedGlobalStateId
> when sending requests to the namenode.
> --------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-16834
> URL: https://issues.apache.org/jira/browse/HDFS-16834
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Simbarashe Dzinamarira
> Assignee: Simbarashe Dzinamarira
> Priority: Major
> Labels: pull-request-available
>
> When sending requests to the namenode, we should only use the
> poolLocalStateId. Maxing it with the sharedGlobalStateId makes reads
> consistent across all clients using a router, which is not necessary and will
> lead to more waiting on the observer.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
