[
https://issues.apache.org/jira/browse/HDFS-16844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634931#comment-17634931
]
ASF GitHub Bot commented on HDFS-16844:
---------------------------------------
omalley commented on code in PR #5138:
URL: https://github.com/apache/hadoop/pull/5138#discussion_r1024284004
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/CachedRecordStore.java:
##########
@@ -125,7 +125,6 @@ public boolean loadCache(boolean force) throws IOException {
} catch (IOException e) {
LOG.error("Cannot get \"{}\" records from the State Store",
getRecordClass().getSimpleName());
- this.initialized = false;
Review Comment:
Actually, this is the most important line in the patch. :)
If initialized goes to false, it will block serving up the contents of the
cache. With the patch the router will be up until
dfs.federation.router.store.membership.expiration expires, in which case the
router goes into safe mode.
> [RBF] The routers should be resiliant against exceptions from StateStore
> ------------------------------------------------------------------------
>
> Key: HDFS-16844
> URL: https://issues.apache.org/jira/browse/HDFS-16844
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: rbf
> Affects Versions: 3.3.4
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Major
> Labels: pull-request-available
>
> Currently, a single exception from the StateStore will cripple a router by
> clearing the caches before the replacement is loaded. Since the routers have
> the information in an in-memory cache, it is better to keep running. There is
> still the timeout that will push the router into safe-mode if it can't load
> the state store over a longer period of time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
