[
https://issues.apache.org/jira/browse/HDFS-16839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635158#comment-17635158
]
ASF GitHub Bot commented on HDFS-16839:
---------------------------------------
tasanuma commented on code in PR #5128:
URL: https://github.com/apache/hadoop/pull/5128#discussion_r1024790669
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##########
@@ -2609,7 +2610,8 @@ DatanodeDescriptor[] chooseSourceDatanodes(BlockInfo
block,
continue; // already reached replication limit
}
- if (node.getNumberOfBlocksToBeReplicated() >=
replicationStreamsHardLimit) {
+ if (node.getNumberOfBlocksToBeReplicated() +
+ node.getNumberOfBlocksToBeErasureCoded()>=
replicationStreamsHardLimit) {
Review Comment:
```suggestion
node.getNumberOfBlocksToBeErasureCoded() >=
replicationStreamsHardLimit) {
```
> It should consider EC reconstruction work when we determine if a node is busy
> -----------------------------------------------------------------------------
>
> Key: HDFS-16839
> URL: https://issues.apache.org/jira/browse/HDFS-16839
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Kidd5368
> Assignee: Kidd5368
> Priority: Major
> Labels: pull-request-available
>
> In chooseSourceDatanodes( ), I think it's more reasonable if we take EC
> reconstruction work as a consideration when we determine if a node is busy or
> not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
