[
https://issues.apache.org/jira/browse/HDFS-16840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635601#comment-17635601
]
ASF GitHub Bot commented on HDFS-16840:
---------------------------------------
ZanderXu commented on code in PR #5129:
URL: https://github.com/apache/hadoop/pull/5129#discussion_r1025926871
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java:
##########
@@ -103,6 +103,10 @@ public class OfflineImageViewerPB {
+ " The default is Web.\n"
+ "-delimiter <arg> Delimiting string to use with Delimited or \n"
+ " DetectCorruption processor. \n"
+ + "-sp Whether to print Storage policy (default is
false). \n"
+ + " Is used by Delimited processor only. \n"
+ + "-ec Whether to print Erasure coding policy
(default is false). \n"
+ + " Is used by Delimited processor only. \n"
Review Comment:
How about adding -maxSize, -step, -format and -addr together?
> Add sp and ec policy opiton description about oiv in HDFSCommands.md
> ---------------------------------------------------------------------
>
> Key: HDFS-16840
> URL: https://issues.apache.org/jira/browse/HDFS-16840
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
>
> Currently support print out storage and erasure coding policy id in oiv
> Delimited output,
> maybe can add relevant information in HDFSCommands.md to describe how to use
> it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
