[
https://issues.apache.org/jira/browse/HDFS-16847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635704#comment-17635704
]
ASF GitHub Bot commented on HDFS-16847:
---------------------------------------
simbadzina opened a new pull request, #5145:
URL: https://github.com/apache/hadoop/pull/5145
HDFS-16847: Prevents StateStoreFileSystemImpl from committing tmp file after
encountering an IOException.
### Description of PR
The file based implementation of the RBF state store has a commit step that
moves a temporary file to a permanent location.
There is a check to see if the write of the temp file was successfully,
however, the code to commit doesn't check the success flag.
This is the relevant code:
https://github.com/apache/hadoop/blob/7d39abd799a5f801a9fd07868a193205ab500bfa/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java#L369
### How was this patch tested?
Ran tests in TestStateStoreFileSystem
### For code changes:
- [ X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
> StateStore writer should not commit tmp fail if there was an error in writing
> the file.
> ---------------------------------------------------------------------------------------
>
> Key: HDFS-16847
> URL: https://issues.apache.org/jira/browse/HDFS-16847
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs, rbf
> Reporter: Simbarashe Dzinamarira
> Assignee: Simbarashe Dzinamarira
> Priority: Critical
>
> The file based implementation of the RBF state store has a commit step that
> moves a temporary file to a permanent location.
> There is a check to see if the write of the temp file was successfully,
> however, the code to commit doesn't check the success flag.
> This is the relevant code:
> [https://github.com/apache/hadoop/blob/7d39abd799a5f801a9fd07868a193205ab500bfa/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java#L369]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
