[
https://issues.apache.org/jira/browse/HDFS-16847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636091#comment-17636091
]
ASF GitHub Bot commented on HDFS-16847:
---------------------------------------
simbadzina commented on PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#issuecomment-1320761423
> Thanks @simbadzina for your contribution.
>
> @goiri - Do you think we can add a specific UT for this change? Also, I
can see the current test has been updated to check it.
>
> I am +1 overall.
Thanks for the reviews @ashutoshcipher and @goiri . In this review I didn't
update tests.
I spent some time trying to add a test but I couldn't find an elegant way to
do use.
I had two ideas
1) Adding a fault injector to StateStoreFileBaseImpl . And then use the
injector to throw an en exception during the write of the file.
2) Mocking StateStoreFileSystemImpl and throwing an exception when the
serializeString(..) method is called.
(1) felt like overkill. I couldn't get (2) to work because serializeString()
is a protected method in a parent class.
If you have any thoughts on a test we can add I'd greatly appreciate
pointers.
> RBF: StateStore writer should not commit tmp fail if there was an error in
> writing the file.
> --------------------------------------------------------------------------------------------
>
> Key: HDFS-16847
> URL: https://issues.apache.org/jira/browse/HDFS-16847
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs, rbf
> Reporter: Simbarashe Dzinamarira
> Assignee: Simbarashe Dzinamarira
> Priority: Critical
> Labels: pull-request-available
>
> The file based implementation of the RBF state store has a commit step that
> moves a temporary file to a permanent location.
> There is a check to see if the write of the temp file was successfully,
> however, the code to commit doesn't check the success flag.
> This is the relevant code:
> [https://github.com/apache/hadoop/blob/7d39abd799a5f801a9fd07868a193205ab500bfa/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java#L369]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
