[
https://issues.apache.org/jira/browse/HDFS-16841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636157#comment-17636157
]
ASF GitHub Bot commented on HDFS-16841:
---------------------------------------
tasanuma commented on code in PR #5137:
URL: https://github.com/apache/hadoop/pull/5137#discussion_r1027088725
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DebugAdmin.java:
##########
@@ -432,8 +432,16 @@ private class VerifyECCommand extends DebugCommand {
VerifyECCommand() {
super("verifyEC",
- "verifyEC -file <file>",
- " Verify HDFS erasure coding on all block groups of the file.");
+ "verifyEC -file <file> [-blockId <blk_Id>] [-ignoreFailures]",
Review Comment:
if the option is specified, it skips this if clause, and it should always
return 0, shouldn't it?
```java
if (!verifyAllFailures) {
return 1;
}
```
> Enhance the function of DebugAdmin#VerifyECCommand
> --------------------------------------------------
>
> Key: HDFS-16841
> URL: https://issues.apache.org/jira/browse/HDFS-16841
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
>
> Currently DebugAdmin#VerifyECCommand supports verify the correctness of
> erasure coding on file. If the first failures block group occurs during
> verify, the verify will end.
> 1.Consider add option to control whether to ignore failures block group . If
> set, will ignores failures block group during verify and continues verify all
> block groups of the file
> 2.add option support for specifying block group to verify
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
