[
https://issues.apache.org/jira/browse/HDFS-16845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636943#comment-17636943
]
ASF GitHub Bot commented on HDFS-16845:
---------------------------------------
omalley commented on code in PR #5142:
URL: https://github.com/apache/hadoop/pull/5142#discussion_r1028642292
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/NameNodeProxiesClient.java:
##########
@@ -349,6 +349,13 @@ public static ClientProtocol
createProxyWithAlignmentContext(
boolean withRetries, AtomicBoolean fallbackToSimpleAuth,
AlignmentContext alignmentContext)
throws IOException {
+ if (conf.getBoolean(HdfsClientConfigKeys.DFS_RBF_OBSERVER_READ_ENABLE,
Review Comment:
I'd simplify the check to
if (alignmentContext == null &&
conf.getBoolean(....)) {
alignmentContext = new ClientGSIContext();
}
> Add configuration flag to enable observer reads on routers without using
> ObserverReadProxyProvider
> --------------------------------------------------------------------------------------------------
>
> Key: HDFS-16845
> URL: https://issues.apache.org/jira/browse/HDFS-16845
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Simbarashe Dzinamarira
> Assignee: Simbarashe Dzinamarira
> Priority: Critical
> Labels: pull-request-available
>
> In order for clients to have routers forward their reads to observers, the
> clients must use a proxy with an alignment context. This is currently
> achieved by using the ObserverReadProxyProvider.
> Using ObserverReadProxyProvider allows backward compatible for client
> configurations.
> However, the ObserverReadProxyProvider forces an msync on initialization
> which is not required with routers.
> Performing msync calls is more expensive with routers because the router fans
> out the cal to all namespaces, so we'd like to avoid this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
