[
https://issues.apache.org/jira/browse/HDFS-16838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637248#comment-17637248
]
ASF GitHub Bot commented on HDFS-16838:
---------------------------------------
ZanderXu commented on PR #5125:
URL: https://github.com/apache/hadoop/pull/5125#issuecomment-1323653147
Sorry for the late update, @xinglin @aajisaka please help me review it
again. Thanks so much.
> Fix NPE in testAddRplicaProcessorForAddingReplicaInMap
> ------------------------------------------------------
>
> Key: HDFS-16838
> URL: https://issues.apache.org/jira/browse/HDFS-16838
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
>
> There is a NPE in
> org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList#testAddRplicaProcessorForAddingReplicaInMap
> if we run this UT individually. And the related bug as bellow:
>
> {code:java}
> public void testAddRplicaProcessorForAddingReplicaInMap() throws Exception {
> // BUG here
> BlockPoolSlice.reInitializeAddReplicaThreadPool();
> Configuration cnf = new Configuration();
> int poolSize = 5;
> ...
> }{code}
>
> _addReplicaThreadPool_ may not have been initialized and is null, if we run
> testAddRplicaProcessorForAddingReplicaInMap unit test as an individual unit
> test.
> {code:java}
> @VisibleForTesting
> public static void reInitializeAddReplicaThreadPool() {
> addReplicaThreadPool.shutdown();
> addReplicaThreadPool = null;
> }{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
