[
https://issues.apache.org/jira/browse/HDFS-16847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637368#comment-17637368
]
ASF GitHub Bot commented on HDFS-16847:
---------------------------------------
simbadzina commented on code in PR #5145:
URL: https://github.com/apache/hadoop/pull/5145#discussion_r1029624340
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/store/driver/TestStateStoreDriverBase.java:
##########
@@ -234,6 +234,25 @@ public <T extends BaseRecord> void testInsert(
assertEquals(11, records2.size());
}
+ public <T extends BaseRecord> void testInsertWithErrorDuringWrite(
Review Comment:
Yeah, this test doesn't capture the error I'd made. I tried changing the
test to do a failure and then a success but I can't get mockito to work right.
Since I'm working with a spy I need to use the doThrow().when(...) syntax.
However, to have a change of behavior I believe mock wants me to use
when(...).doThrow().doCallRealMethod().
@mkuchenbecker If it is okay, I'll leave the test as it is. It exposes the
original bug in the code and validate that my patch address it.
> RBF: StateStore writer should not commit tmp fail if there was an error in
> writing the file.
> --------------------------------------------------------------------------------------------
>
> Key: HDFS-16847
> URL: https://issues.apache.org/jira/browse/HDFS-16847
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs, rbf
> Reporter: Simbarashe Dzinamarira
> Assignee: Simbarashe Dzinamarira
> Priority: Critical
> Labels: pull-request-available
>
> The file based implementation of the RBF state store has a commit step that
> moves a temporary file to a permanent location.
> There is a check to see if the write of the temp file was successfully,
> however, the code to commit doesn't check the success flag.
> This is the relevant code:
> [https://github.com/apache/hadoop/blob/7d39abd799a5f801a9fd07868a193205ab500bfa/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java#L369]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
