[
https://issues.apache.org/jira/browse/HDFS-16658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638510#comment-17638510
]
ASF GitHub Bot commented on HDFS-16658:
---------------------------------------
tasanuma commented on PR #4559:
URL: https://github.com/apache/hadoop/pull/4559#issuecomment-1327061231
Hi, @ZanderXu.
May I ask what percentage of the `BLOCK* addStoredBlock:` logs are in the
total logs of NameNode in your cluster? Doesn't this change affect the
performance of NameNode?
> BlockManager should output some logs when logEveryBlock is true.
> ----------------------------------------------------------------
>
> Key: HDFS-16658
> URL: https://issues.apache.org/jira/browse/HDFS-16658
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> During locating some abnormal cases in our prod environment, I found that
> BlockManager does not out put some logs in `addStoredBlock` even though
> `logEveryBlock` is true.
> I feel that we need to change the log level from DEBUG to INFO.
> {code:java}
> // Some comments here
> private Block addStoredBlock(final BlockInfo block,
> final Block reportedBlock,
> DatanodeStorageInfo storageInfo,
> DatanodeDescriptor delNodeHint,
> boolean logEveryBlock)
> throws IOException {
> ....
> if (logEveryBlock) {
> blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
> node, storedBlock, storedBlock.getNumBytes());
> }
> ...
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
