[
https://issues.apache.org/jira/browse/HDFS-16809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642234#comment-17642234
]
ASF GitHub Bot commented on HDFS-16809:
---------------------------------------
tasanuma commented on code in PR #5050:
URL: https://github.com/apache/hadoop/pull/5050#discussion_r1037731995
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeAdminManager.java:
##########
@@ -353,7 +353,7 @@ protected boolean isSufficient(BlockInfo block,
BlockCollection bc,
}
}
if (isMaintenance
- && numLive >= blockManager.getMinReplicationToBeInMaintenance()) {
+ && numLive >= blockManager.getMinMaintenanceStorageNum(block)) {
Review Comment:
Please make it one line to fix a checkstyle warning.
```java
if (isMaintenance && numLive >=
blockManager.getMinMaintenanceStorageNum(block)) {
```
> EC striped block is not sufficient when doing in maintenance
> ------------------------------------------------------------
>
> Key: HDFS-16809
> URL: https://issues.apache.org/jira/browse/HDFS-16809
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ec, erasure-coding
> Reporter: dingshun
> Assignee: dingshun
> Priority: Major
> Labels: pull-request-available
>
> When doing maintenance, ec striped block is not sufficient, which will lead
> to miss block
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
