[ 
https://issues.apache.org/jira/browse/HDFS-16861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643184#comment-17643184
 ] 

ASF GitHub Bot commented on HDFS-16861:
---------------------------------------

Neilxzn opened a new pull request, #5184:
URL: https://github.com/apache/hadoop/pull/5184

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   https://issues.apache.org/jira/browse/HDFS-16861
   
   ### How was this patch tested?
   add truncate api test in TestRouterAllResolver
   
   ### For code changes:
   in RouterClientProtocol
   ```
     @Override
     public boolean truncate(String src, long newLength, String clientName)
         throws IOException {
   ...
       // Truncate can return true/false, so don't expect a result
       return rpcClient.invokeSequential(locations, method, Boolean.class,
           null);
     }
   ```
   
   




> RBF. Truncate API always fails when dirs use AllResolver oder on Router  
> -------------------------------------------------------------------------
>
>                 Key: HDFS-16861
>                 URL: https://issues.apache.org/jira/browse/HDFS-16861
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: rbf
>    Affects Versions: 3.4.0
>            Reporter: Max  Xie
>            Priority: Major
>         Attachments: image-2022-12-05-17-35-19-841.png
>
>
> # prepare a directory in a HASH_ALL/SPACE/RANDOM mount point.
>  # put  a test file with 1024 bytes  to this directory
>  # truncate the file with 100 new length  and this op will fail and throw  a 
> exception that the file does not exist.
>  
> After dig it, we should ignore the result of Truncate API in 
> RouterClientProtocol because
> Truncate can return true/false, so don't expect a result.
> After fix it , the code is 
> !image-2022-12-05-17-35-19-841.png!
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to