[
https://issues.apache.org/jira/browse/HDFS-16861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645949#comment-17645949
]
ASF GitHub Bot commented on HDFS-16861:
---------------------------------------
Neilxzn commented on code in PR #5184:
URL: https://github.com/apache/hadoop/pull/5184#discussion_r1045475166
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java:
##########
@@ -411,9 +411,8 @@ public boolean setReplication(String src, short replication)
RemoteMethod method = new RemoteMethod("setReplication",
new Class<?>[] {String.class, short.class}, new RemoteParam(),
replication);
- if (rpcServer.isInvokeConcurrent(src)) {
- return !rpcClient.invokeConcurrent(locations, method, Boolean.class)
- .containsValue(false);
+ if (rpcServer.isPathAll(src)) {
Review Comment:
I think the logic of `setReplication` api should be consistent with
`delete` api. This change will ok.
> RBF. Truncate API always fails when dirs use AllResolver oder on Router
> -------------------------------------------------------------------------
>
> Key: HDFS-16861
> URL: https://issues.apache.org/jira/browse/HDFS-16861
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: rbf
> Affects Versions: 3.4.0
> Reporter: Max Xie
> Assignee: Max Xie
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2022-12-05-17-35-19-841.png
>
>
> # prepare a directory in a HASH_ALL/SPACE/RANDOM mount point.
> # put a test file with 1024 bytes to this directory
> # truncate the file with 100 new length and this op will fail and throw a
> exception that the file does not exist.
>
> After dig it, we should ignore the result of Truncate API in
> RouterClientProtocol because
> Truncate can return true/false, so don't expect a result.
> After fix it , the code is
> !image-2022-12-05-17-35-19-841.png!
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
