[
https://issues.apache.org/jira/browse/HDFS-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194997#comment-13194997
]
Aaron T. Myers commented on HDFS-2843:
--------------------------------------
bq. This information is used by secondary namenode, checkpointer, backup node
as well. Does that still make it "storage"?
I don't see how this fact makes it necessarily *not* storage. All those things
have "storage" directories as well.
bq. Distributed upgrade was used only once long back and is not in use any
more. It is the regular upgrade that considers layout version and CTime etc.
Sure, but the point still remains. What about during an upgrade process? What
if this information (e.g. layoutVersion) differs between storage directories on
a single node at some moment in time?
bq. I am not proposing any change in the VERSION file. All I am saying is, call
this part NodeInfo instead of StorageInfo. All this information is still
present in all the data structures.
I realize, but at least the layoutVersion field does seem
storage-directory-specific, and hence should not be described as being at the
node level.
bq. I plan to cleanup the hierarchy of classes where StorageInfo is super class
of bunch of other classes such DataStorage, BlockPoolSliceStorage, Storage etc.
Perhaps it would be clearer how this proposed name change makes sense if we
could see how you envision the end state? At the moment, this incremental
change doesn't make sense to me.
Also, what about my other concern from earlier? I can probably be convinced
that a name change for StorageInfo is in order, but not StorageInfoProto in
isolation:
{quote}
Regardless, if we do go ahead with a name change, it doesn't make sense to me
that we would change StorageInfoProto but not StorageInfo itself, given that
StorageInfoProto is really just a serialization class of StorageInfo. If the
semantic of the name StorageInfoProto is wrong, then surely StorageInfo is as
well, right?
{quote}
> Rename protobuf message StorageInfoProto to NodeInfoProto
> ---------------------------------------------------------
>
> Key: HDFS-2843
> URL: https://issues.apache.org/jira/browse/HDFS-2843
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HDFS-2843.patch
>
>
> StorageInfoProto has cTime, layoutVersion, namespaceID and clusterID. This is
> really information of a node that is part of the cluster, such as Namenode,
> Standby/Secondary/Backup/Checkpointer and datanodes. To reflect this, I want
> to rename it as NodeInfoProto from StorageInfoProto.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
