[
https://issues.apache.org/jira/browse/HDFS-16877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653779#comment-17653779
]
ASF GitHub Bot commented on HDFS-16877:
---------------------------------------
mkuchenbecker commented on code in PR #5257:
URL: https://github.com/apache/hadoop/pull/5257#discussion_r1060273952
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:
##########
@@ -203,6 +203,9 @@ public class RouterRpcServer extends AbstractService
implements ClientProtocol,
/** Router using this RPC server. */
private final Router router;
+ /** RouterStateIdContext for this RPC server. */
Review Comment:
Nit. Prefer comments that explain rather than describe the code.
```
/** Interface to map global name space to HDFS subcluster name spaces. */
private final FileSubclusterResolver subclusterResolver;
```
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java:
##########
@@ -510,6 +513,15 @@ BalanceProcedureScheduler getFedRenameScheduler() {
return this.fedRenameScheduler;
}
+ /**
+ * Get the routerStateIdContext used by this server.
+ * @return routerStateIdContext
+ */
+ @VisibleForTesting
+ public RouterStateIdContext getRouterStateIdContext() {
Review Comment:
Does protected not work? i.e. Your test should be able to access a protected
member.
> Namenode doesn't use alignment context in TestObserverWithRouter
> ----------------------------------------------------------------
>
> Key: HDFS-16877
> URL: https://issues.apache.org/jira/browse/HDFS-16877
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs, rbf
> Reporter: Simbarashe Dzinamarira
> Priority: Major
> Labels: pull-request-available
>
> We need to set "{*}dfs.namenode.state.context.enabled{*}" to true for the
> namenode to send it's stateId in client responses.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
