[
https://issues.apache.org/jira/browse/HDFS-16881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655690#comment-17655690
]
ASF GitHub Bot commented on HDFS-16881:
---------------------------------------
ayushtkn commented on code in PR #5268:
URL: https://github.com/apache/hadoop/pull/5268#discussion_r1063999307
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java:
##########
@@ -628,6 +628,12 @@ public class DFSConfigKeys extends CommonConfigurationKeys
{
public static final String
DFS_NAMENODE_READ_LOCK_REPORTING_THRESHOLD_MS_KEY =
"dfs.namenode.read-lock-reporting-threshold-ms";
public static final long
DFS_NAMENODE_READ_LOCK_REPORTING_THRESHOLD_MS_DEFAULT = 5000L;
+
+ public static final String
DFS_NAMENODE_ACCESS_CONTROL_ENFORCER_REPORTING_THRESHOLD_MS_KEY
+ = "dfs.namenode.access-control-enforcer-reporting-threshold-ms";
+ public static final long
DFS_NAMENODE_ACCESS_CONTROL_ENFORCER_REPORTING_THRESHOLD_MS_DEFAULT
+ = 1000L;
Review Comment:
Could have supported time units like
``DFS_LOCK_SUPPRESS_WARNING_INTERVAL_KEY`` rather than binding with ``ms``
> Warn if AccessControlEnforcer runs for a long time to check permission
> ----------------------------------------------------------------------
>
> Key: HDFS-16881
> URL: https://issues.apache.org/jira/browse/HDFS-16881
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namanode
> Reporter: Tsz-wo Sze
> Assignee: Tsz-wo Sze
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> AccessControlEnforcer is configurable. If an external AccessControlEnforcer
> runs for a long time to check permission with the FSnamesystem lock, it will
> significantly slow down the entire Namenode. In the JIRA, we will print a
> WARN message when it happens.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
