[
https://issues.apache.org/jira/browse/HDFS-16885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655702#comment-17655702
]
ASF GitHub Bot commented on HDFS-16885:
---------------------------------------
szetszwo commented on code in PR #5283:
URL: https://github.com/apache/hadoop/pull/5283#discussion_r1064004688
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml:
##########
@@ -1240,6 +1240,15 @@
</description>
</property>
+<property>
+ <name>dfs.namenode.access-control-enforcer-reporting-threshold-ms</name>
+ <value>1000</value>
+ <description>
+ If an external AccessControlEnforcer runs for a long time to check
permission with the FSnamesystem lock,
+ we will print a WARN message when it happens. This sets how long must be
run for logging to occur.
Review Comment:
Change `we will print a WARN message when it happens` to `print a WARN log
message`.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml:
##########
@@ -1240,6 +1240,15 @@
</description>
</property>
+<property>
+ <name>dfs.namenode.access-control-enforcer-reporting-threshold-ms</name>
Review Comment:
Please move this right below `dfs.namenode.read-lock-reporting-threshold-ms`
since they are related.
> Fix TestHdfsConfigFields#testCompareConfigurationClassAgainstXml failed
> -----------------------------------------------------------------------
>
> Key: HDFS-16885
> URL: https://issues.apache.org/jira/browse/HDFS-16885
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
>
> A new parameter "dfs.namenode.access-control-enforcer-reporting-threshold-ms"
> was introduced in HDFS-16881.
> However, this parameter was not added to hdfs-default.xml, cause run
> TestHdfsConfigFields#testCompareConfigurationClassAgainstXml failed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
