[
https://issues.apache.org/jira/browse/HDFS-16884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655795#comment-17655795
]
ASF GitHub Bot commented on HDFS-16884:
---------------------------------------
tomscut commented on code in PR #5280:
URL: https://github.com/apache/hadoop/pull/5280#discussion_r1064145313
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java:
##########
@@ -662,6 +662,9 @@ public void run() {
for (Future<?> f : futureList) {
f.get();
}
+ // Wait for the async deletion task finish.
+ GenericTestUtils.waitFor(() ->
dataset.asyncDiskService.countPendingDeletions() == 0,
+ 100, 1000);
Review Comment:
Maybe 1 second is too short. Can we update it to 10 seconds?
> Fix TestFsDatasetImpl#testConcurrentWriteAndDeleteBlock failed
> --------------------------------------------------------------
>
> Key: HDFS-16884
> URL: https://issues.apache.org/jira/browse/HDFS-16884
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
>
> Since the default is async delete replica on the datanode, the replica may
> not be deleted during the execution of UT#testConcurrentWriteAndDeleteBlock,
> resulting in a mismatch between the number of replicas in each dataset
> obtained at the end and the expectation
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
