[ 
https://issues.apache.org/jira/browse/HDFS-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195735#comment-13195735
 ] 

Uma Maheswara Rao G commented on HDFS-2841:
-------------------------------------------

Aaron, Patch looks great.
I also verified the patch, it works fine.

small nit:
following code should be formatted to single line.
{code}
 throw new IOException(
-            "Couldn't create proxy provider " + failoverProxyProviderClass, e);
+            message, e);
{code}

+1 from my side after addressing this nit.

                
> HA: HAAdmin does not work if security is enabled
> ------------------------------------------------
>
>                 Key: HDFS-2841
>                 URL: https://issues.apache.org/jira/browse/HDFS-2841
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Critical
>         Attachments: HDFS-2841-HDFS-1623.patch
>
>
> Though HAServiceProtocol is indeed annotated with the {{@KerberosInfo}} 
> annotation, it specifies the Common server principal, which is intended to be 
> overridden at run-time with the value of the correct principal (e.g. as is 
> done in MRAdmin and DFSAdmin.) We need to do something similar for HAAdmin.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to