[ 
https://issues.apache.org/jira/browse/HDFS-16917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689408#comment-17689408
 ] 

ASF GitHub Bot commented on HDFS-16917:
---------------------------------------

xinglin commented on code in PR #5397:
URL: https://github.com/apache/hadoop/pull/5397#discussion_r1107877375


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeMetrics.java:
##########
@@ -61,6 +61,8 @@ public class DataNodeMetrics {
   @Metric MutableCounterLong bytesRead;
   @Metric("Milliseconds spent reading")
   MutableCounterLong totalReadTime;
+  @Metric MutableRate bytesReadTransferRate;

Review Comment:
   nit: rename to readTransferRateMBs?





> Add transfer rate quantile metrics for DataNode reads
> -----------------------------------------------------
>
>                 Key: HDFS-16917
>                 URL: https://issues.apache.org/jira/browse/HDFS-16917
>             Project: Hadoop HDFS
>          Issue Type: Task
>          Components: datanode
>            Reporter: Ravindra Dingankar
>            Priority: Minor
>              Labels: pull-request-available
>
> Currently we have the following metrics for datanode reads.
> |BytesRead
> BlocksRead
> TotalReadTime|Total number of bytes read from DataNode
> Total number of blocks read from DataNode
> Total number of milliseconds spent on read operation|
> We would like to add a new quantile metric calculating the distribution of 
> data transfer rate for datanode reads.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to