[ 
https://issues.apache.org/jira/browse/HDFS-16942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698653#comment-17698653
 ] 

ASF GitHub Bot commented on HDFS-16942:
---------------------------------------

virajjasani commented on PR #5460:
URL: https://github.com/apache/hadoop/pull/5460#issuecomment-1463012342

   >  I also don't understand why this style warning is appearing, as its not a 
new package folder, and it has plenty of other classes in it already.
   
   I think it's appearing because it was not resolved earlier or it was 
ignored. For instance, I see the last time the module was touched was by this 
PR #4252 and in the last QA result, I see checkstyle issues, but of course 
since the PR is quite old, we can't see what the error was (it reports 404 for 
the checkstyle report page).
   I guess it's not that important either.
   
   
   > This isn't working. I added what you suggested, but still the same error.
   
   Strange, I think this one should hopefully work:
   
   ```
   -

> Send error to datanode if FBR is rejected due to bad lease
> ----------------------------------------------------------
>
>                 Key: HDFS-16942
>                 URL: https://issues.apache.org/jira/browse/HDFS-16942
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode, namenode
>            Reporter: Stephen O'Donnell
>            Assignee: Stephen O'Donnell
>            Priority: Major
>              Labels: pull-request-available
>
> When a datanode sends a FBR to the namenode, it requires a lease to send it. 
> On a couple of busy clusters, we have seen an issue where the DN is somehow 
> delayed in sending the FBR after requesting the least. Then the NN rejects 
> the FBR and logs a message to that effect, but from the Datanodes point of 
> view, it thinks the report was successful and does not try to send another 
> report until the 6 hour default interval has passed.
> If this happens to a few DNs, there can be missing and under replicated 
> blocks, further adding to the cluster load. Even worse, I have see the DNs 
> join the cluster with zero blocks, so it is not obvious the under replication 
> is caused by lost a FBR, as all DNs appear to be up and running.
> I believe we should propagate an error back to the DN if the FBR is rejected, 
> that way, the DN can request a new lease and try again.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to