[ 
https://issues.apache.org/jira/browse/HDFS-16948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700307#comment-17700307
 ] 

ASF GitHub Bot commented on HDFS-16948:
---------------------------------------

Kidd53685368 commented on PR #5474:
URL: https://github.com/apache/hadoop/pull/5474#issuecomment-1468464509

   
   @zhangshuyan0 Thank you, that makes sense.
   
   > Even if `delStorageHint` is not null, `processChosenExcessRedundancy()` 
may not be executed when delHint is not duplicated. I suggest adding a flag 
that is set to `false` after `processChosenExcessRedundancy()` is executed. 
Only log when the flag is `true`.
   
   




> Do not print "excess types chosen ... is empty" when EC internal block is 
> moved by balancer
> -------------------------------------------------------------------------------------------
>
>                 Key: HDFS-16948
>                 URL: https://issues.apache.org/jira/browse/HDFS-16948
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.3.4
>            Reporter: Kidd5368
>            Assignee: Kidd5368
>            Priority: Major
>              Labels: pull-request-available
>
> This is a follow-up of HDFS-16179.When the EC internal block is moved by the 
> balancer, it will trigger chooseExcessRedundancyStriped( ), and the parameter 
> delNodeHint is not null.So the nonExcess list will be modified in 
> processChosenExcessRedundancy( ), normally the size of nonExcess will be 
> reduced to the expected EC group size, that's why the annoying log "excess 
> types chose ... is empty." will be printed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to