[
https://issues.apache.org/jira/browse/HDFS-16948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701082#comment-17701082
]
ASF GitHub Bot commented on HDFS-16948:
---------------------------------------
Hexiaoqiao commented on code in PR #5474:
URL: https://github.com/apache/hadoop/pull/5474#discussion_r1138457077
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##########
@@ -4155,8 +4157,10 @@ private void
chooseExcessRedundancyStriped(BlockCollection bc,
final List<StorageType> excessTypes = storagePolicy.chooseExcess(
(short) numOfTarget, DatanodeStorageInfo.toStorageTypes(nonExcess));
if (excessTypes.isEmpty()) {
- LOG.warn("excess types chosen for block {} among storages {} is empty",
- storedBlock, nonExcess);
+ if(logEmptyExcessType) {
Review Comment:
`if (logEmptyExcessType && excessTypes.isEmpty())` should be more readable.
> Update log of BlockManager#chooseExcessRedundancyStriped when EC internal
> block is moved by balancer
> ----------------------------------------------------------------------------------------------------
>
> Key: HDFS-16948
> URL: https://issues.apache.org/jira/browse/HDFS-16948
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 3.3.4
> Reporter: Kidd5368
> Assignee: Kidd5368
> Priority: Major
> Labels: pull-request-available
>
> This is a follow-up of HDFS-16179.When the EC internal block is moved by the
> balancer, it will trigger chooseExcessRedundancyStriped( ), and the parameter
> delNodeHint is not null.So the nonExcess list will be modified in
> processChosenExcessRedundancy( ), normally the size of nonExcess will be
> reduced to the expected EC group size, that's why the annoying log "excess
> types chose ... is empty." will be printed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
