[ 
https://issues.apache.org/jira/browse/HDFS-16957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701513#comment-17701513
 ] 

ASF GitHub Bot commented on HDFS-16957:
---------------------------------------

virajjasani commented on PR #5487:
URL: https://github.com/apache/hadoop/pull/5487#issuecomment-1473142805

   @ayushtkn @goiri
   I just looked at the function where the changes are made in the PR and 
realized that other options `-setQuota`, `-setStorageTypeQuota`, `-clrQuota` 
and `-clrStorageTypeQuota` also have the same problem and they are also not 
consistent. I have not tested these options yet but with a quick glance, I feel 
they also are likely having the same issue.
   
   Would you recommend fixing them all once and for all on trunk (3.4.0) only 
with this PR?




> RBF: Exit status of dfsrouteradmin -rm should be non-zero for unsuccessful 
> attempt
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-16957
>                 URL: https://issues.apache.org/jira/browse/HDFS-16957
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>              Labels: pull-request-available
>
> DFS router admin returns non-zero status code for unsuccessful attempt to add 
> or update mount point. However, same is not the case with removal of mount 
> point.
> For instance,
> {code:java}
> bin/hdfs dfsrouteradmin -add /data4 ns1 /data4
> ..
> ..
> Cannot add destination at ns1 /data4
> echo $?
> 255 {code}
> {code:java}
> /hadoop/bin/hdfs dfsrouteradmin -rm /data4
> ..
> ..
> Cannot remove mount point /data4
> echo $?
> 0{code}
> Removal of mount point should stay consistent with other options and return 
> non-zero (unsuccessful) status code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to