[
https://issues.apache.org/jira/browse/HDFS-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703218#comment-17703218
]
ASF GitHub Bot commented on HDFS-16954:
---------------------------------------
Neilxzn commented on PR #5483:
URL: https://github.com/apache/hadoop/pull/5483#issuecomment-1477887166
> The test class `TestRouterAllResolver.java` doesn't look like the correct
place for this scenario to me The Javadoc for the class says
>
> ```
> /**
> * Tests the use of the resolvers that write in all subclusters from the
> * Router. It supports:
> * <li>HashResolver
> * <li>RandomResolver.
> */
> ```
>
> And this is testing rename RPC, Can we explore adding a test in
`TestRouterRpcMultiDestination` or in
`TestRouterRPCMultipleDestinationMountTableResolver`
@ayushtkn I try to add this test in `TestRouterRpcMultiDestination` . But in
`TestRouterRpcMultiDestination`, we can't run tests of router with multi
destination because of `TestRouterRpcMultiDestination` use `MockResolver` .
RouterRpcServer#isPathAll always return false.
```
# RouterRpcServer#isPathAll
boolean isPathAll(final String path) {
if (subclusterResolver instanceof MountTableResolver) {
try {
MountTableResolver mountTable = (MountTableResolver)
subclusterResolver;
MountTable entry = mountTable.getMountPoint(path);
if (entry != null) {
return entry.isAll();
}
} catch (IOException e) {
LOG.error("Cannot get mount point", e);
}
}
return false;
}
```
> RBF: The operation of renaming a multi-subcluster directory to a
> single-cluster directory should throw ioexception
> ------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-16954
> URL: https://issues.apache.org/jira/browse/HDFS-16954
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: rbf
> Affects Versions: 3.4.0
> Reporter: Max Xie
> Assignee: Max Xie
> Priority: Minor
> Labels: pull-request-available
>
> The operation of renaming a multi-subcluster directory to a single-cluster
> directory may cause inconsistent behavior of the file system. This operation
> should throw exception to be reasonable.
> Examples are as follows:
> 1. add hash_all mount point `hdfs dfsrouteradmin -add /tmp/foo
> subcluster1,subcluster2 /tmp/foo -order HASH_ALL`
> 2. add mount point `hdfs dfsrouteradmin -add /user/foo subcluster1
> /user/foo`
> 3. mkdir dir for all subcluster. ` hdfs dfs -mkdir /tmp/foo/123 `
> 4. check dir and all subclusters will have dir `/tmp/foo/123`
> `hdfs dfs -ls /tmp/foo/` : will show dir `/tmp/foo/123`;
> `hdfs dfs -ls hdfs://subcluster1/tmp/foo/` : will show dir
> `hdfs://subcluster1/tmp/foo/123`;
> `hdfs dfs -ls hdfs://subcluster2/tmp/foo/` : will show dir
> `hdfs://subcluster2/tmp/foo/123`;
> 5. rename `/tmp/foo/123` to `/user/foo/123`. The op will succeed. `hdfs dfs
> -mv /tmp/foo/123 /user/foo/123 `
> 6. check dir again, rbf cluster still show dir `/tmp/foo/123`
> `hdfs dfs -ls /tmp/foo/` : will show dir `/tmp/foo/123`;
> `hdfs dfs -ls hdfs://subcluster1/tmp/foo/` : will no dirs;
> `hdfs dfs -ls hdfs://subcluster2/tmp/foo/` : will show dir
> `hdfs://subcluster2/tmp/foo/123`;
> The step 5 should throw exception.
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
