[
https://issues.apache.org/jira/browse/HDFS-16963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704451#comment-17704451
]
ASF GitHub Bot commented on HDFS-16963:
---------------------------------------
szetszwo commented on PR #5505:
URL: https://github.com/apache/hadoop/pull/5505#issuecomment-1482220494
The checkstyle warning is about the test method name `testFS_SYMLINKS` not
matting the expected pattern. FS_SYMLINKS is for the constant name and this is
just a test. Let's just ignore the checkstyle warning.
> Remove the unnecessary use of Optional from DistributedFileSystem
> -----------------------------------------------------------------
>
> Key: HDFS-16963
> URL: https://issues.apache.org/jira/browse/HDFS-16963
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: fs
> Reporter: Tsz-wo Sze
> Assignee: Tsz-wo Sze
> Priority: Major
> Labels: pull-request-available
>
> - In DfsPathCapabilities, the hasPathCapability(..) method may simply returns
> boolean.
> - In HdfsPathHandle, a constructor declares Optional parameters. It is a
> well known misuse of Optional.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
