[ 
https://issues.apache.org/jira/browse/HDFS-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704970#comment-17704970
 ] 

ASF GitHub Bot commented on HDFS-16959:
---------------------------------------

virajjasani commented on PR #5497:
URL: https://github.com/apache/hadoop/pull/5497#issuecomment-1483884585

   For the test, if we want to be accurate about 
`mountTableCacheLoadAvgTimeMs`, there is a better way too: we can use 
`FakeTimer` impl and inject it to `CachedRecordStore` by retrieving state store 
cache list `cachesToUpdateInternal` from the state store service. 
   I think this might be overkill for the current Jira though. If you like this 
idea, I can take it up as separate task, but for prod, we are not achieving 
anything and maybe this is too much for tests as well.




> RBF: State store cache loading metrics
> --------------------------------------
>
>                 Key: HDFS-16959
>                 URL: https://issues.apache.org/jira/browse/HDFS-16959
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>              Labels: pull-request-available
>
> With increasing num of state store records (like mount points), it would be 
> good to be able to get the cache loading metrics like avg time for cache load 
> during refresh, num of times cache is loaded etc.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to