[ 
https://issues.apache.org/jira/browse/HDFS-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196956#comment-13196956
 ] 

Robert Joseph Evans commented on HDFS-2835:
-------------------------------------------

I did not intend to have the other code in the patch.  Findbugs gave me some 
extra warnings that went away after doing a clean and rerunning findbugs, but 
not before I started trying to fix those other warnings.  Thanks for catching 
that.

I like your patch it fixes the issue just as well as my patch.  In either case 
this is just defensive programming as that enum is never actually serialized in 
the code.

+1.
                
> Fix org.apache.hadoop.hdfs.tools.GetConf$Command Findbug issue
> --------------------------------------------------------------
>
>                 Key: HDFS-2835
>                 URL: https://issues.apache.org/jira/browse/HDFS-2835
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: tools
>    Affects Versions: 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: HDFS-2835.txt, HDFS-2835.txt
>
>
> https://builds.apache.org/job/PreCommit-HDFS-Build/1804//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
>  shows a findbugs warning.  It is unrelated to the patch being tested, and 
> has shown up on a few other JIRAS as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to