[
https://issues.apache.org/jira/browse/HDFS-16971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17710360#comment-17710360
]
ASF GitHub Bot commented on HDFS-16971:
---------------------------------------
simbadzina commented on code in PR #5536:
URL: https://github.com/apache/hadoop/pull/5536#discussion_r1162196442
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java:
##########
@@ -851,8 +851,9 @@ protected synchronized int readWithStrategy(ReaderStrategy
strategy)
locatedBlocks.getFileLength() - pos);
}
}
+ long beginRead = Time.monotonicNow();
Review Comment:
Add time unit. `MS`
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java:
##########
@@ -1184,6 +1185,7 @@ void actualGetFromOneDataNode(final DNAddrPair datanode,
final long startInBlk,
ByteBuffer tmp = buf.duplicate();
tmp.limit(tmp.position() + len);
tmp = tmp.slice();
+ long beginRead = Time.monotonicNow();
Review Comment:
Add unit, `MS`
> Add read time metrics for remote reads in Statistics
> ----------------------------------------------------
>
> Key: HDFS-16971
> URL: https://issues.apache.org/jira/browse/HDFS-16971
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Reporter: Melissa You
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.3.0, 3.4.0
>
>
> In Filesystem.java, currently it only collects bytes read not the
> corresponding timing of reads.
> In particular, we're interested in time spent on remote reads(not local
> reads). Adding timing info will help us understand it better and further
> analyze how locality of DN behaves.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
